Visual comparison

  • <div class="divider"> provides blue borders

waves

  • <pre> has different borders (solid on SECOORA vs. dotted on SEACOOS)
  • 'Selected Wave Activities' table has borders on SEACOOS but not SECOORA
  • <img...><a...> which point out of SECOORA have an icon not found on SEACOOS
  • some tds overlap (in Firefox, not Opera)

HTML issues

  • Content is contained within <table>
  • Minor issue: correctly indented code would be nice (for the rare occasion when someone like us actually looks at it!)

waves

  • <div class="divider"> should be replaced by <hr/> with style border:0; border-bottom:solid 1px #00f
  • Half of the description is in meta-data; the other half is in <p> (can't have links in description)
  • 987-999: list of links is <h5>, not <ul>; lots of &nbsp;s
  • 1070-1071: <br> used instead of margin-bottom
  • 1163-1522: <table> without <tbody> or <th>s
  • 1165: valign="bottom" should be in CSS
  • 1165-1169, etc. (tds): <td><p align="center">... is wasteful; td should have style text-align:center; don't need <p> within <td> for one-liners
  • 1167, etc. (headings): <strong><span>Wave Activities</span></strong> should be replaced with th and correctly styled: font-weight:bold; text-align:center
  • 1188, etc.: <p><span> is wasteful
  • target="_blank" should not be used (see mistake 2 of Jakob Nielsen's top 10)
  • 1023-1025: list of links is <h5>, not <ul>
  • 1051, etc. (target="blank"): see above

lesson-plans/home-on-the-beach/index_html

  • 1050: <p style="text-align: center; font-size: 150%;"><strong> used instead of heading tag
  • 1051: <p style="text-align: center;"><em> should be heading as well
  • 1052, etc.: <p><strong>OBJECTIVES:</strong> should be heading
  • 1080: <table> should not be used to wrap text around image; instead use float:right
  • 1108: <table border="1" border-style="solid" width="100%"> should be in CSS
  • 1115, etc.: <br>Group A<br>&nbsp; is wasteful; replace <br>s with line-height; remove unnecessary &nbsp;s

lesson-plans/wind-waves/index_html

  • 1048: need to use heading tags for headings
  • 1103: data table needs to be redone (same for 'Home on the Beach'):
    • Borders should be done using CSS
      • <table> has style border:solid 1px black; border-width:1px 1px 0 0
      • <td> has style border:solid 1px black; border-width:0 0 1px 1px
    • Headings need to be in <th>
    • <td> needs padding
    • <tr> needs height

CSS issues

  • We should probably set max-width or even width on body. As the width increases, line-length increases making it harder to read.
  • Need more whitespace between elements (margin, padding, line-height)

waves

  • 987: <h5 style="text-align:center; color:#4040ff;">
  • 988-998: <a href="#MakingWavesPoster"><span style="color:#4040ff; text-decoration:underline;">
  • 997, etc.: <img alt="" class="kicker" src="MakingWavesPoster.png">
  • 999-1001, etc. ('back to top' links): <td style="text-align:right;"><a href="#top" style="color:#4040ff; text-decoration: underline;">back&nbsp;to&nbsp;top</a></td>
  • 1088, etc. (subheadings): <h4 style="text-align:center;">
  • 1163-1522: <table class="simple" cellspacing="0" cellpadding="0" width="100%">
    • this class is probably unnecessary; ideally this would be the only table on the page (it's the only real tabular data on the page), meaning we don't need a class to apply CSS to it id=activities
  • 1239, etc. (activity names in table): <p class="indent-small">
  • 1588: <img alt="" src="tsunami.png" style="margin:10px 0px 5px 0px;">
  • 1594: <ul class="noindent">

tsunami-resource-links

  • 1020: <h5 style="text-align:center; color:#4040ff;">
  • 1021, etc. (links): <a href=".."><span style="color:#4040ff; text-decoration:underline;">; span is unnecessary; apply styles directly to a:link, etc.
  • 1023: <h5 style="text-align:center; color:#4040ff;">
  • 1035, etc. ('back to top' links): see above
  • 1041, etc. (subheadings): see above

education-standards

  • 773, etc.: <h4 class="custom-headc">
  • 775, etc.: <h5 class="custom-heada">
  • 778, etc.: <h6 class="custom-headb">
  • Probably should use page-specific CSS using <body id="education-standards"> and #education-standards h4, etc. (can't do that)

Image issues

  • All images have description meta-data as they did on SEACOOS

Images used as headings

  • http://secoora.net/classroom/waves/makingwavesposter.png
  • http://secoora.net/classroom/waves/wavepresentation.png
  • http://secoora.net/classroom/waves/wavefactsheet.png
  • http://secoora.net/classroom/waves/waveactivities.png
  • http://secoora.net/classroom/waves/waveglossary.png
  • http://secoora.net/classroom/waves/tsunamiresourcelinks.png
  • http://secoora.net/classroom/waves/moreaboutwavesclassroom.png
  • http://secoora.net/classroom/waves/wavereferences.png
  • http://secoora.net/classroom/waves/makingwavessurvey.png
  • http://secoora.net/classroom/waves/tsunami-resource-links/classroomactivities.png
  • http://secoora.net/classroom/waves/tsunami-resource-links/visualizations.png
  • http://secoora.net/classroom/waves/tsunami-resource-links/informationreferences.png

File issues

  • lesson-plans/wind-waves/index_html has no description

Non-HTML content

  • webwaves.ppt
  • waves-fact-sheet.doc
  • home-on-the-beach.doc
  • making-waves.doc
  • wind-waves.doc
  • wave-size-and-depth.doc
  • Sciencestandards-wave.doc
  • glossary.doc
  • Wavepostersurvey.doc

'Home on the Beach' and 'Wind Waves' have HTML versions which are not currently used.

Short names

  • 'tsunami-resources-links' should be renamed to 'resources' 'tsunami-resources'
  • lesson-plans/*/index_html need to be renamed 'activities/...'

Copy issues

waves

  • Erroneous comma: "Learn about concepts, such as..."
  • Don't use COOLroom acronym before using full name.

tsunami-resource-links

  • The resources page isn't really 'a special feature' in the sense that similar pages are provided with the other classrooms; we should omit that entire sentence.
  • 1331: 'Lookup Look up...'
  • Source for lesson plans (eduplace.com) isn't cited (or even mentioned)
  • Univ. of Washington resource isn't cited

Other issues

  • There are folders for home-on-the-beach and making-waves which are supposed to contain HTML versions of those activities, but don't
  • There is a folder for waves-fact-sheet which doesn't contain an HTML version of the fact sheet

waves

tsunami-resource-links